Re: [RFC 06/11] core: Make connection properties exist only when connected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrzej,

On Tue, May 20, 2014, Andrzej Kaczmarek wrote:
> +static gboolean dev_property_exists_conn(const GDBusPropertyTable *property,
> +								void *data)
> +{
> +	struct btd_device *device = data;
> +
> +	/* TODO: only exists when monitoring is enabled? */
> +	return btd_device_is_connected(device) ? TRUE : FALSE;

To answer this open, yes, I think the properties should only be
available when there is someone that has requested monitoring of them.
If you didn't fix this later in the set please do it for the first
non-RFC set that you send. I haven't seen anything else too
objectionable in this set.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux