Re: [PATCH] android: Include headers from libhardware as system headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

On 22 May 2014 09:32, Szymon Janc <szymon.janc@xxxxxxxxx> wrote:
> Hi Andrzej,
>
> On Wednesday 21 of May 2014 18:18:02 Andrzej Kaczmarek wrote:
>> Including hardware/audio.h in Android build produces sign-compare
>> warning due to nested include of cutils/bitops.h. Since we cannot avoid
>> this warning in sane way unless it's fixed in AOSP tree, we can make
>> GCC think this is a system header and suppress warnings.
>>
>> This patch changes the way headers from libhardware are added to
>> search path from LOCAL_C_INCLUDES to explicit "-isystem" option added
>> to LOCAL_CFLAGS.
>> ---
>>  android/Android.mk | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/android/Android.mk b/android/Android.mk
>> index 4235a7c..d3d94ed 100644
>> --- a/android/Android.mk
>> +++ b/android/Android.mk
>> @@ -121,12 +121,12 @@ LOCAL_SRC_FILES := \
>
> I'd rather fix this in AOSP instead of hacking this in our build system.

I agree, I pushed patch for this already:
https://android-review.googlesource.com/95341

BR,
Andrzej
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux