Re: [PATCH 05/12] android/bluetooth: Expose API to update sign counter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On 21 May 2014 15:16, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Lukasz,
>
> On Wed, May 21, 2014, Lukasz Rymanowski wrote:
>> +void bt_update_sign_counter(const bdaddr_t *addr, bool local);
>
> This doesn't make for a good API since you can't know which counter
> bt_update_sign_counter(bdaddr, true/false) updates without looking at
> the actual implementation. Either create a two-value enum or have two
> separate functions to make the calling code more readable.
>

Ok, will add enum here.

> Johan

Thanks
Lukasz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux