Re: [PATCH] shared/tester: Add support for debug logs for tester

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Grzegorz,

On Wed, May 07, 2014, Grzegorz Kolodziejczyk wrote:
> +void tester_debug(const char *format, ...)
> +{
> +	va_list ap;
> +
> +	if (!tester_use_debug())
> +		return;
> +
> +	printf("   tester-dbg: %s", COLOR_WHITE);

I think it'd be good to make the prefix consistent with the other
logging functions here. Do we really need to know that a line is a debug
print? Isn't it simply enough that the line is printed when debugging is
enabled? I don't see any special identifiers for the other types of logs
either. So unless there's a good reason to have it I'd just keep this
consistent with the other logs.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux