Hi Antonio, On Wednesday 14 of May 2014 23:40:01 Antonio Ospite wrote: > Hi, > > here's the updated patch series, the commit messages have been fixed too! > > I am leaving out patch 1/5 for now: > > plugins/sixaxis: Simplify get_js_numbers() > > I decided to do so because there is still some timing issue: the new > procedure to retrieve the js number is faster, and on the _very_first_ > run it fails and returns 0, I suspect this has to do with the fact that > the joydev module gets loaded after the hidraw uevent and the > enumeration in the plugin completes before the js node shows up in > sysfs, I'll do some more experiments on that. > > So please apply only patches from 2 to 5, thanks, I kept the numbering > as in v1 for clarity. > > Changes since v1 are annotated in each patch. > > The changes have been tested with libudev-204 along with linux-3.13, > linux 3.14 and linux-3.15-rc4. > > To recap: > - on kernels < 3.14 the hidraw mechanism is used > - on kernels >= 3,14 the sysfs mechanism is used to avoid > inconsistencies with rumble effects. > > Thanks, > Antonio > > Antonio Ospite (4): > plugins/sixaxis: Factor out a set_leds_hidraw() function > plugins/sixaxis: Factor out a calc_leds_bitmap() function > plugins/sixaxis: Add a get_leds_data() function > plugins/sixaxis: Add a set_leds_sysfs() function > > configure.ac | 4 +- > plugins/sixaxis.c | 178 +++++++++++++++++++++++++++++++++++++++++++++++------- > 2 files changed, 158 insertions(+), 24 deletions(-) I've applied patches 2/5 and 3/5 so no need to resend those. Thanks. -- Best regards, Szymon Janc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html