Re: [PATCH v3 1/5] Bluetooth: Add conn info lifetime parameters to debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrzej,

> This patch adds conn_info_min_age and conn_info_max_age parameters to
> debugfs which determine lifetime of connection information. Actual
> lifetime will be random value between min and max age.
> 
> Default values for min and max age are 1000ms and 3000ms respectively.
> 
> Signed-off-by: Andrzej Kaczmarek <andrzej.kaczmarek@xxxxxxxxx>
> ---
> include/net/bluetooth/hci_core.h | 6 ++++++
> net/bluetooth/hci_core.c         | 7 +++++++
> 2 files changed, 13 insertions(+)
> 
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index 211bad6..4623f45 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -145,6 +145,10 @@ struct oob_data {
> /* Default LE RPA expiry time, 15 minutes */
> #define HCI_DEFAULT_RPA_TIMEOUT		(15 * 60)
> 
> +/* Default min/max age of connection information (1s/3s) */
> +#define DEFAULT_CONN_INFO_MIN_AGE	1000
> +#define DEFAULT_CONN_INFO_MAX_AGE	3000
> +
> struct amp_assoc {
> 	__u16	len;
> 	__u16	offset;
> @@ -200,6 +204,8 @@ struct hci_dev {
> 	__u16		le_conn_min_interval;
> 	__u16		le_conn_max_interval;
> 	__u16		discov_interleaved_timeout;
> +	__u16		conn_info_min_age;
> +	__u16		conn_info_max_age;
> 	__u8		ssp_debug_mode;
> 
> 	__u16		devid_source;
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index d31f144..62ebcea 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1754,6 +1754,11 @@ static int __hci_init(struct hci_dev *hdev)
> 			    &blacklist_fops);
> 	debugfs_create_file("uuids", 0444, hdev->debugfs, hdev, &uuids_fops);
> 
> +	debugfs_create_u16("conn_info_min_age", 0644, hdev->debugfs,
> +			   &hdev->conn_info_min_age);
> +	debugfs_create_u16("conn_info_max_age", 0644, hdev->debugfs,
> +			   &hdev->conn_info_max_age);
> +

I know this is dead simple, but I rather have this done similar to how we do the sniff_max_interval and sniff_min_interval. So that you can not set wrong values or bad ranges.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux