Re: [RFC 1/2] shared/aes-cmac: Add support for AES-CMAC-128

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On 13 May 2014 15:24, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Lukasz,
>
>> This patch adds handling AES-CMAC-128 signing as specified in the NIST
>> Special Publication 800-38B
>> ---
>> src/shared/aes-cmac.c | 346 ++++++++++++++++++++++++++++++++++++++++++++++++++
>> src/shared/aes-cmac.h |  38 ++++++
>> 2 files changed, 384 insertions(+)
>> create mode 100644 src/shared/aes-cmac.c
>> create mode 100644 src/shared/aes-cmac.h
>
> I really like to see it included in src/shared/crypto.c. Lets try that one first. It is meant to provide the whole crypto toolbox for us.

I tried but it did not look good to me then.

Anyway, what I need to do is to add to struct bt_crypro a member which
will contain aes-cmac session data (key, sub keys, sign_counter)
I need to also mess a bit with bt_crypto_new and add there parameters
needed to initialize AES-CMAC ?
Is that a good way?

>
>>
>> diff --git a/src/shared/aes-cmac.c b/src/shared/aes-cmac.c
>> new file mode 100644
>> index 0000000..660ceff
>> --- /dev/null
>> +++ b/src/shared/aes-cmac.c
>> @@ -0,0 +1,346 @@
>> +/*
>> + *
>> + *  BlueZ - Bluetooth protocol stack for Linux
>> + *
>> + *  Copyright (C) 2014  Intel Corporation. All rights reserved.
>> + *
>> + *
>> + *  This library is free software; you can redistribute it and/or
>> + *  modify it under typedef struct {
>> +     uint64_t a, b;
>> +} u128;the terms of the GNU Lesser General Public
>
> Something is broken here.
>
How that happen (?) Thanks.

> Regards
>
> Marcel
>
BR
\Łukasz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux