Hi Petri, On Thu, May 08, 2014, Petri Gynther wrote: > 1. Fix potential buffer overflow. It would happen in the case: > hogdev->has_report_id == TRUE && report_size == UHID_DATA_MAX > > 2. Adjust function signature to match GAttribNotifyFunc. > > 3. Adjust uHID error handling to mimic uhid_send_input_report() in > profiles/input/device.c > --- > profiles/input/hog.c | 44 +++++++++++++++++++++++++++++--------------- > 1 file changed, 29 insertions(+), 15 deletions(-) Whenever I see a commit message like this it begs the question: shouldn't these separate fixes be in separate patches? If at all possible please split the patch into smaller ones so that each one contains a single independent fix. That makes it much easier to track exactly which code change maps to which described fix as well the possibility to do some bisecting later in case one of the fixes introduces a bug. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
