Hi Johan, On Tuesday 29 of April 2014 10:57:18 Johan Hedberg wrote: > Hi, > > On Tue, Apr 29, 2014, Lukasz Rymanowski wrote: > > --- > > android/gatt.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/android/gatt.c b/android/gatt.c > > index 0e81e7d..ed4ee75 100644 > > --- a/android/gatt.c > > +++ b/android/gatt.c > > @@ -599,6 +599,11 @@ failed: > > static void send_client_disconnection_notify(struct app_connection *connection, > > int32_t status) > > { > > + /* disconnect and connect events are binary the same so its safe to pass > > + * hal_ev_gatt_client_disconnect struct even for connect event. > > + * Note that server do this the right way, having single event for > > + * connection state notification. > > + */ > > I believe the user space commenting style (if we try to be consistent) > is to have an empty line in the beginning of a multi-line comment. Yeah, we are a bit inconsistent wrt multi-line comments in android folder. I'll push bulk patch that fix this. -- Best regards, Szymon Janc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html