Hi, On Thu, Apr 24, 2014 at 08:43:05AM +1000, NeilBrown wrote: > On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon <nm@xxxxxx> wrote: > > > On 04/23/2014 09:58 AM, Felipe Balbi wrote: > > > nobody passes a DTR_gpio to this driver, so > > > this code is not necessary. > > > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > > --- > > > > Niel, > > this seems to revert the functionality introduced in > > commit 9574f36fb801035f6ab0fbb1b53ce2c12c17d100 > > (OMAP/serial: Add support for driving a GPIO as DTR.) > > > > would you like to Ack this change? > > I have a couple of out-of-tree drivers that use this support. > > I hope to get back to working on that code one day and even get those drivers > upstream. So I would really prefer this code to remain if it isn't causing > any actual problems. it causes problem with DT (not really). That suport is only available on legacy platform_data-based boot, it's not available on DT. I hear Tony is pretty close to turning OMAP3 DT-only. > Of course, I can always re-submit it when I need it again, but that it just > extra work all around. I wonder how you will pass those attributes through DT considering they are *really* SW configuration. Why can't you use the real DTR pin, btw ? -- balbi
Attachment:
signature.asc
Description: Digital signature
