Hi Andrei,
On Thursday 17 of April 2014 15:23:45 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>
> Fixes static analyzers NULL dereference warnings. The similar check is
> done in src/device.c in line 2959.
> ---
> android/handsfree.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/android/handsfree.c b/android/handsfree.c
> index 02b6dad..c8026a0 100644
> --- a/android/handsfree.c
> +++ b/android/handsfree.c
> @@ -1405,6 +1405,9 @@ static void sdp_hsp_search_cb(sdp_list_t *recs, int err, gpointer data)
> goto fail;
> }
>
> + if (!classes)
> + goto fail;
> +
This is already checked :
if (sdp_get_service_classes(recs->data, &classes) < 0 || !classes) {
error("handsfree: unable to get service classes from record");
goto fail;
}
What kind of warning do you get from static analyzer?
> if (sdp_get_access_protos(recs->data, &protos) < 0) {
> error("handsfree: unable to get access protocols from record");
> sdp_list_free(classes, free);
> @@ -1495,6 +1498,9 @@ static void sdp_hfp_search_cb(sdp_list_t *recs, int err, gpointer data)
> goto fail;
> }
>
> + if (!classes)
> + goto fail;
> +
Ditto.
> if (sdp_get_access_protos(recs->data, &protos) < 0) {
> error("handsfree: unable to get access protocols from record");
> sdp_list_free(classes, free);
>
--
Best regards,
Szymon Janc
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
