Hi Marcin, On Wed, Apr 9, 2014 at 4:07 AM, Marcin Kraglak <marcin.kraglak@xxxxxxxxx> wrote: > It will stop service in local database. > --- > android/gatt.c | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/android/gatt.c b/android/gatt.c > index edcb7aa..f5324f3 100644 > --- a/android/gatt.c > +++ b/android/gatt.c > @@ -2881,10 +2881,34 @@ failed: > > static void handle_server_stop_service(const void *buf, uint16_t len) > { > + const struct hal_cmd_gatt_server_stop_service *cmd = buf; > + struct hal_ev_gatt_server_service_stopped ev; > + struct gatt_server *server; > + uint8_t status; "status" could be initialized to "HAL_STATUS_FAILED" > + > DBG(""); > > + server = find_server_by_id(cmd->server_if); > + if (!server) { > + status = HAL_STATUS_FAILED; > + goto failed; > + } > + > + if (!gatt_db_stop_service(gatt_db, cmd->service_handle)) > + status = HAL_STATUS_FAILED; > + else > + status = HAL_STATUS_SUCCESS; > + > +failed: > + ev.status = status == HAL_STATUS_SUCCESS ? GATT_SUCCESS : GATT_FAILURE; Use conversion helper (hal ->gatt)? > + ev.server_if = cmd->server_if; > + ev.srvc_handle = cmd->service_handle; > + > + ipc_send_notif(hal_ipc, HAL_SERVICE_ID_GATT, > + HAL_EV_GATT_SERVER_SERVICE_STOPPED, sizeof(ev), &ev); > + > ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_GATT, > - HAL_OP_GATT_SERVER_STOP_SERVICE, HAL_STATUS_FAILED); > + HAL_OP_GATT_SERVER_STOP_SERVICE, status); > } > > static void handle_server_delete_service(const void *buf, uint16_t len) > -- > 1.8.5.3 > Claudio -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html