Re: [RFC 09/16] android/gatt: Add implementation of delete service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcin,

On Wed, Apr 9, 2014 at 4:07 AM, Marcin Kraglak <marcin.kraglak@xxxxxxxxx> wrote:
> It will delete saervice from local database
> ---
>  android/gatt.c | 30 +++++++++++++++++++++++++++++-
>  1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 76753a8..5f054c7 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -2767,10 +2767,38 @@ static void handle_server_stop_service(const void *buf, uint16_t len)
>
>  static void handle_server_delete_service(const void *buf, uint16_t len)
>  {
> +       const struct hal_cmd_gatt_server_delete_service *cmd = buf;
> +       struct hal_ev_gatt_server_service_deleted ev;
> +       struct gatt_server *server;
> +       uint8_t status;
> +

"status" could be initialized to "HAL_STATUS_FAILED"

>         DBG("");
>
> +       memset(&ev, 0, sizeof(ev));
> +
> +       server = find_server_by_id(cmd->server_if);
> +       if (!server) {
> +               status = HAL_STATUS_FAILED;
> +               goto failed;
> +       }
> +
> +       if (!gatt_db_remove_service(gatt_db, cmd->service_handle)) {
> +               status = HAL_STATUS_FAILED;
> +               goto failed;
> +       }
> +
> +       status = HAL_STATUS_SUCCESS;
> +
> +failed:
> +       ev.status = status == HAL_STATUS_SUCCESS ? GATT_SUCCESS : GATT_FAILURE;

Same comment of the previous patch.

> +       ev.srvc_handle = cmd->service_handle;
> +       ev.server_if = cmd->server_if;
> +
> +       ipc_send_notif(hal_ipc, HAL_SERVICE_ID_GATT,
> +               HAL_EV_GATT_SERVER_SERVICE_DELETED, sizeof(ev), &ev);
> +
>         ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_GATT,
> -                       HAL_OP_GATT_SERVER_DELETE_SERVICE, HAL_STATUS_FAILED);
> +                       HAL_OP_GATT_SERVER_DELETE_SERVICE, status);
>  }
>
>  static void handle_server_send_indication(const void *buf, uint16_t len)

Claudio
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux