Re: [PATCH v2 5/5] android/gatt: Fix type of status parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Łukasz,

On Thursday 10 of April 2014 17:30:05 Lukasz Rymanowski wrote:
> ---
>  android/gatt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index 235e9e4..cdca424 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -509,7 +509,7 @@ static void connection_cleanup(struct gatt_device *device)
>  }
>  
>  static void send_client_disconnect_notify(int32_t id, struct gatt_device *dev,
> -								uint8_t status)
> +								int32_t status)
>  {
>  	struct hal_ev_gatt_client_disconnect ev;
>  
> 

I've applied this patch, but please check why this function is always called
success status. Shouldn't we call this callback with fail status if
handle_client_disconnect() failed?

-- 
Best regards, 
Szymon Janc
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux