Hi Loic, On Thu, Apr 03, 2014, Loic Poulain wrote: > From: lpoulain <loic.poulain@xxxxxxxxx> You need to fix your git author information before this goes upstream. The above should say "First Last <email>". > Add a bcm43xx specific init sequence in hciattach > in order to initialize bcm43xx controllers. > --- > v6: Coding style > > Makefile.tools | 3 +- > tools/hciattach.c | 11 +- > tools/hciattach.h | 2 + > tools/hciattach_bcm43xx.c | 374 ++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 388 insertions(+), 2 deletions(-) > create mode 100644 tools/hciattach_bcm43xx.c The code looks fine now but doesn't actually compile: CC tools/hciattach_bcm43xx.o tools/hciattach_bcm43xx.c: In function ‘bcm43xx_read_local_name’: tools/hciattach_bcm43xx.c:90:2: error: implicit declaration of function ‘free’ [-Werror=implicit-function-declaration] free(resp); ^ tools/hciattach_bcm43xx.c:90:2: error: incompatible implicit declaration of built-in function ‘free’ [-Werror] cc1: all warnings being treated as errors make[1]: *** [tools/hciattach_bcm43xx.o] Error 1 I believe that's because you've forgotten to #include <stdlib.h> which is needed by free(). Always compile test with ./bootstrap-configure && make Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
