Hi Andre, On Mon, Mar 24, 2014, Andre Guedes wrote: > This patch introduces commands to add and remove connection parameters. > --- > doc/mgmt-api.txt | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 83 insertions(+), 1 deletion(-) All in all this looks pretty good to me. Just one thing I'd fix: > +Add Connection Parameters Command > +==================================== > + > + Command Code: 0x0032 > + Controller Index: <controller id> > + Command Parameters: Address (6 Octets) > + Address_Type (1 Octet) > + Auto_Connect_Option (1 Octet) > + Min_Connection_Interval (2 Octets) > + Max_Connection_Interval (2 Octes) > + Return Parameters: > + This should have the Address and Address_Type also in the return parameters for consistency and ability to distinguish the completion of two simultaneous commands for the different devices. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
