Hi Lukasz,
> This patch add support for read remote rssi.
> This is needed for example for proximity scenarios.
>
> Signed-off-by: Lukasz Rymanowski <lukasz.rymanowski@xxxxxxxxx>
> ---
> include/net/bluetooth/hci.h | 10 +++++
> include/net/bluetooth/hci_core.h | 3 ++
> include/net/bluetooth/mgmt.h | 10 +++++
> net/bluetooth/hci_event.c | 24 ++++++++++++
> net/bluetooth/mgmt.c | 82 ++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 129 insertions(+)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 4261a67..2e023e8 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -1064,6 +1064,16 @@ struct hci_rp_read_page_scan_type {
> #define PAGE_SCAN_TYPE_STANDARD 0x00
> #define PAGE_SCAN_TYPE_INTERLACED 0x01
>
> +#define HCI_OP_READ_REMOTE_RSSI 0x1405
> +struct hci_cp_read_remote_rssi {
> + __le16 handle;
> +} __packed;
> +struct hci_rp_read_remote_rssi {
> + __u8 status;
> + __le16 handle;
> + __s8 rssi;
> +} __packed;
> +
> #define HCI_OP_READ_LOCAL_AMP_INFO 0x1409
> struct hci_rp_read_local_amp_info {
> __u8 status;
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index abd38a2..95837b7 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -1283,6 +1283,9 @@ void mgmt_new_csrk(struct hci_dev *hdev, struct smp_csrk *csrk,
> bool persistent);
> void mgmt_reenable_advertising(struct hci_dev *hdev);
> void mgmt_smp_complete(struct hci_conn *conn, bool complete);
> +void mgmt_read_remote_rssi_complete(struct hci_dev *hdev, bdaddr_t *bdaddr,
> + u8 link_type, u8 addr_type, s8 rssi,
> + u8 status);
>
> /* HCI info for socket */
> #define hci_pi(sk) ((struct hci_pinfo *) sk)
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index d4b571c..16a0201 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -409,6 +409,16 @@ struct mgmt_cp_load_irks {
> } __packed;
> #define MGMT_LOAD_IRKS_SIZE 2
>
> +#define MGMT_OP_READ_REMOTE_RSSI 0x0031
> +#define MGMT_READ_REMOTE_RSSI_SIZE MGMT_ADDR_INFO_SIZE
> +struct mgmt_cp_read_remote_rssi {
> + struct mgmt_addr_info addr;
> +} __packed;
> +struct mgmt_rp_read_remote_rssi {
> + struct mgmt_addr_info addr;
> + __s8 rssi;
> +} __packed;
I am not really in favor of doing it like this. Normally what you really want to do have is a mgmt function that can enable RSSI reporting based on a threshold that changes and a polling interval. So that the kernel will go on and poll the RSSI during the time of the connection and just report it back.
So I say we hold off on this until we have solved all other Android implementation details and then we revisit what we need.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
