Hi Johan: On Mon, Mar 24, 2014 at 5:58 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Claudio, > > On Fri, Mar 21, 2014, Claudio Takahasi wrote: >> This patch adds a function callback for write operations. When a remote >> device writes to a given attribute, the core calls the specified write >> callback informing the attribute server the new characteristic value. >> --- >> src/gatt-dbus.c | 2 +- >> src/gatt.c | 7 ++++--- >> src/gatt.h | 13 ++++++++++++- >> 3 files changed, 17 insertions(+), 5 deletions(-) > > I've applied the first patch but your change to the header file in this > patch is strange: > >> +/* >> + * Callbacks from this type are called once the value from the attribute was >> + * written. >> + * @err: error in -errno format. >> + * @user_data: user_data passed in btd_attr_write_t callback >> + */ >> +typedef void (*btd_attr_write_t) (struct btd_attribute *attr, >> + const uint8_t *value, size_t len); > > There's neither an err parameter nor a user_data parameter in this > callback, so I'm wondering what your code comment refers to? :) > > Johan It belongs to another patch that introduces Write Request handling: asynchronous support. It is a leftover issue of my approach of re-creating all the patches based on the code that I have. I will send another patchset moving this comment to the right patch. Regards, Claudio -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
