Re: [PATCH v2 1/5] core: Move EIR flags definitions to eir.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

On Sun, Mar 23, 2014, Szymon Janc wrote:
> ---
>  src/adapter.c | 15 ++++-----------
>  src/eir.h     |  9 +++++++++
>  2 files changed, 13 insertions(+), 11 deletions(-)
> diff --git a/src/adapter.c b/src/adapter.c

This patch is otherwise fine, but please don't rename the defines. The
EIR prefix is good enough and keeps the usage of the readable enough.
Also, even if we did want to rename them, it's misleading to hide that
in a patch which you (in the commit message) claim to be only about
moving stuff around.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux