Re: [PATCH v2 2/2] Bluetooth: Fix smp_e byte order to be consistent with SMP specification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

> The SMP specification is written with the assumption that both key
> information, plaintextData and encryptedData follow the same little
> endian byte ordering as the rest of SMP.
> 
> Since the kernel crypto routines expect big endian data the code has had
> to do various byte swapping tricks to make the behavior as expected,
> however the swapping has been scattered all around the place.
> 
> This patch centralizes the byte order swapping into the smp_e function
> by making its public interface match what the other SMP functions expect
> as per specification. The benefit is vastly simplified calls to smp_e.
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> ---
> v2: Fix stk generation
> 
> net/bluetooth/smp.c | 101 ++++++++++++++++++++++++----------------------------
> 1 file changed, 46 insertions(+), 55 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux