Hi Andrei,
On Tue, Mar 18, 2014 at 10:25 AM, Andrei Emeltchenko
<andrei.emeltchenko.news@xxxxxxxxx> wrote:
> Hi Luiz,
>
> On Mon, Mar 17, 2014 at 03:07:49PM +0200, Luiz Augusto von Dentz wrote:
>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>>
>> The correct status should 0x04 not 0x00.
>> ---
>> unit/test-avrcp.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
>> index 9fdbe6d..ed0c3fc 100644
>> --- a/unit/test-avrcp.c
>> +++ b/unit/test-avrcp.c
>> @@ -435,7 +435,10 @@ static int set_addressed(struct avrcp *session, uint8_t transaction,
>> {
>> DBG("");
>>
>> - return 1;
>> + avrcp_set_addressed_player_rsp(session, transaction,
>> + AVRCP_STATUS_SUCCESS);
>> +
>> + return -EAGAIN;
>> }
>>
>> static const struct avrcp_control_ind control_ind = {
>> @@ -547,7 +550,7 @@ int main(int argc, char *argv[])
>> raw_pdu(0x02, 0x11, 0x0e, AVC_CTYPE_STABLE,
>> 0x48, 0x00, 0x00, 0x19, 0x58,
>> AVRCP_SET_ADDRESSED_PLAYER,
>> - 0x00, 0x00, 0x01, 0x00));
>> + 0x00, 0x00, 0x01, 0x04));
>
> I would put it 0x00, 0x00, 0x01, AVRCP_STATUS_SUCCESS));
I prefer not to input defines in the raw PDU, the reason is that it
just gets in your way to debug what values are wrong when using
hexdump, also some defines that you are using such as PDU ids should
probably not be exposed now that we have proper functions mapping to
them.
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
