Hi Joe, > The use of __constant_<foo> has been unnecessary for quite awhile now. > > Make these uses consistent with the rest of the kernel. > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > --- > >> can you please send this one against bluetooth-next tree. > > Sure. Here. btw: > > The bandwidth uses of 0x1f40 are kind of unreadable to me. > I think they'd be better as 8000 > > Also some of the hex constants uses seem odd where comments > don't seem to match the number like: > > /* Connection accept timeout ~20 secs */ > - param = __constant_cpu_to_le16(0x7d00); > + param = cpu_to_le16(0x7d00); > > 0x7d00 is 32000, presumably that's 32 seconds. so it is 0x7d00 * 0.625 which results in 20 seconds. > > and > > /* 160 msec page scan interval */ > - acp.interval = __constant_cpu_to_le16(0x0100); > + acp.interval = cpu_to_le16(0x0100); > > 256 msecs? also here 0x0100 * 0.625 resulting in 160 msecs. > net/bluetooth/a2mp.c | 4 +- > net/bluetooth/hci_conn.c | 26 ++++++------- > net/bluetooth/hci_core.c | 2 +- > net/bluetooth/hci_event.c | 6 +-- > net/bluetooth/hci_sock.c | 16 ++++---- > net/bluetooth/l2cap_core.c | 90 ++++++++++++++++++++++----------------------- > net/bluetooth/l2cap_sock.c | 6 +-- > net/bluetooth/mgmt.c | 26 ++++++------- > net/bluetooth/rfcomm/core.c | 4 +- > net/bluetooth/sco.c | 10 ++--- > net/bluetooth/smp.c | 2 +- > 11 files changed, 96 insertions(+), 96 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
