Re: [PATCH] tools: Fix using uninitialized value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Mon, Mar 03, 2014, Andrei Emeltchenko wrote:
> Fixes warning:
> tools/ibeacon.c:150:14: warning: The left expression of the compound
> assignment is an uninitialized value. The computed value will also be
> garbage
>         cmd.data[2] |= 0x02;            /* LE General Discoverable Mode
> */
>         ~~~~~~~~~~~ ^
> 1 warning generated.
> ---
>  tools/ibeacon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/ibeacon.c b/tools/ibeacon.c
> index 458f9e7..2071c6b 100644
> --- a/tools/ibeacon.c
> +++ b/tools/ibeacon.c
> @@ -147,7 +147,7 @@ static void adv_tx_power_callback(const void *data, uint8_t size,
>  
>  	cmd.data[0] = 0x02;		/* Field length */
>  	cmd.data[1] = 0x01;		/* Flags */
> -	cmd.data[2] |= 0x02;		/* LE General Discoverable Mode */
> +	cmd.data[2] = 0x02;		/* LE General Discoverable Mode */
>  	cmd.data[2] |= 0x04;		/* BR/EDR Not Supported */
>  
>  	cmd.data[3] = 0x1a;		/* Field length */

Applied. Thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux