Re: [PATCHv2 3/8] shared/hfp: Add initial implementiation of processing commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

>> +	if (data[result.offset] == '+')
+		return process_extended(hfp, &result);
+	else
+		return process_basic(hfp, &result);

Please do not do this. I mentioned this before, this basic vs extended is pointless.

Command matching should be either based on commands like “D” or “+BRSF” and not bother trying to treat the + any special. See how src/emulator.c in oFono registers all the handlers.


There is a difference in syntax between basic commands and extended commands. HFP only uses two basic commands, namely ATD and ATA so they might be simply handled as a special case. Others are implicit, e.g. ATE, ATV, etc.

Regards,
-Denis

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux