Re: [PATCHv2 4/9] avrcp: Fix buffer size check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Fri, Feb 28, 2014 at 3:18 PM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@xxxxxxxxx> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>
> Fix size check taking into account that attributes starts from 1 (0 is
> illegal).
> ---
>  profiles/audio/avrcp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index c0e5d07..48c3355 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -1909,7 +1909,7 @@ static void avrcp_get_current_player_value(struct avrcp *session,
>         struct avrcp_header *pdu = (void *) buf;
>         uint16_t length = AVRCP_HEADER_LENGTH + count + 1;
>
> -       if (count > AVRCP_ATTRIBUTE_LAST + 1)
> +       if (count > AVRCP_ATTRIBUTE_LAST)
>                 return;
>
>         memset(buf, 0, sizeof(buf));
> --
> 1.8.3.2

This does not apply anymore, there is no check inside
avrcp_get_current_player_value.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux