Hi Andre, >>> + if (hci_update_random_address(&req, false, &own_addr_type)) >>> + return; >> >> Don't we want require_privacy = true here? > > require_privacy = true enables non-resolvable address. Since this is a > passive scanning (no SCAN_REQ is sent), I don't think this is > required. that is correct, it is not strictly speaking needed. However I would prefer we set this to true anyway and add a proper comment for it like we do with the other places. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html