Hi Johan,
> When powering on the controller and deciding what value to set to
> hdev->own_address_time take also into account the HCI_PRIVACY flag (in
> which case random own address should be used).
>
> Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> ---
> net/bluetooth/hci_core.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 964aa8deb009..753a73ba6764 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1477,14 +1477,16 @@ static void hci_init3_req(struct hci_request *req, unsigned long opt)
>
> if (lmp_le_capable(hdev)) {
> /* If the controller has a public BD_ADDR, then by default
> - * use that one. If this is a LE only controller without
> - * a public address, default to the random address.
> + * use that one, unless Privacy is enabled. If this is a LE
> + * only controller without a public address, default to
> + * the random address.
> *
> * For debugging purposes it is possible to force
> * controllers with a public address to use the
> * random address instead.
> */
> - if (test_bit(HCI_FORCE_STATIC_ADDR, &hdev->dev_flags) ||
> + if (test_bit(HCI_PRIVACY, &hdev->dev_flags) ||
> + test_bit(HCI_FORCE_STATIC_ADDR, &hdev->dev_flags) ||
> !bacmp(&hdev->bdaddr, BDADDR_ANY))
> hdev->own_addr_type = ADDR_LE_DEV_RANDOM;
this patch is actually wrong. The hdev->own_addr_type should refer to the identity address. That one is either public address or static random address.
We need to check the address type we set for each command and set either hdev->own_addr_type if privacy is off or when privacy is on use ADDR_LE_DEV_RANDOM.
Please remember that we need to send the identity address type over SMP. So we need to know which one that is.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
