Hi Marcel,
On Tue, Feb 18, 2014, Marcel Holtmann wrote:
> > + cmd = find_pairing(conn);
> > + if (!cmd)
> > + BT_DBG("Unable to find a pending command”);
>
> why do we bother with the debug print here?
>
> > + else
> > + pairing_complete(cmd, status);
>
> I would just do this:
>
> if (cmd)
> pairing_complete(cmd, status);
>
> Unless you have future patches that do more work here.
The main reason was to get some idea how frequently this function gets
called unnecessarily, but you're right in that it's kind of useless.
I've removed it in my latest set.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
