Hi Luiz, On Tue, Jan 28, 2014 at 06:56:25AM -0800, Luiz Augusto von Dentz wrote: > Hi Andrei, > > On Tue, Jan 28, 2014 at 4:34 AM, Andrei Emeltchenko > <Andrei.Emeltchenko.news@xxxxxxxxx> wrote: > > From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > > > There is currently inconsistence in the avctp code with > > AVC_HEADER_LENGTH defined in avctp.h but AVCTP_HEADER_LENGTH defined in > > avctp.c. The patch moves structure definitions to the header in > > consistent way. > > I wonder why you did not do the opposite, move AVC_HEADER_LENGTH into > avctp.c since the AVC packet control is all done inside avctp.c it > should probably not be exposed. I do actually think that avctp.c is wrong place to deal with AVC since AVCTP shouldn't handle it but anyway I will move it there. Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html