Hi Szymon,
> There is no need to report very small RSSI changes.
> ---
> android/bluetooth.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/android/bluetooth.c b/android/bluetooth.c
> index b105ac8..b95023c 100644
> --- a/android/bluetooth.c
> +++ b/android/bluetooth.c
> @@ -1045,6 +1045,19 @@ static uint8_t bdaddr_type2android(uint8_t type)
> return HAL_TYPE_LE;
> }
>
> +static bool rssi_threashold(int old, int new)
lets write it threshold ;)
And I think a better name would be is_above_threshold or rssi_above_threshold.
> +{
> + int delta;
> +
> + if (old > new)
> + delta = old - new;
> + else
> + delta = new - old;
> +
> + /* only 8 dBm or more */
> + return delta >= 8;
int delta = old > new ? old - new : new - old;
> +}
> +
> static void update_found_device(const bdaddr_t *bdaddr, uint8_t bdaddr_type,
> int8_t rssi, bool confirm,
> const uint8_t *data, uint8_t data_len)
> @@ -1113,7 +1126,7 @@ static void update_found_device(const bdaddr_t *bdaddr, uint8_t bdaddr_type,
> (*num_prop)++;
> }
>
> - if (rssi) {
> + if (rssi && rssi_threashold(dev->rssi, rssi)) {
> dev->rssi = rssi;
>
> size += fill_hal_prop(buf + size, HAL_PROP_DEVICE_RSSI,
One other idea might to just use rate limit on the timestamp. Only report once every x seconds.
The inquiry TX on the remote side might not be always the same for every device. If we want to be precise we have to make sure to get the TX power level from EIR and calculate the path loss.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
