Hi Marcel, On Thu, Jan 23, 2014, Marcel Holtmann wrote: > > There's no reason why A2DP should need or deserve its on channel type. > > I assume you mean A2MP here? > > > Instead we should be able to group all fixed CID users under a single > > channel type and reuse as much code as possible for them. Where CID > > specific exceptions are needed the chan-scid value can be used. > > > > This patch renames the current A2DP channel type to a generic one and > > Same here. Yep. Seems like typing A2DP is somehow hardwired into my brain after so many years. > > -#define L2CAP_CHAN_CONN_FIX_A2MP 4 > > +#define L2CAP_CHAN_FIXED_CID 4 > > You want to use FIXED_CID instead of just FIXED. I am fine with > FIXED_CID, just double checking here. I was thinking of it as "channel with a fixed CID", however now that I re-read the Core Spec it talks about "Fixed Channels", so I'll change this simply to CHAN_FIXED. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
