Hi Johan,
On 01/07/2014 10:59 AM, Johan Hedberg wrote:
Hi Ravi,
On Mon, Jan 06, 2014, Ravi kumar Veeramally wrote:
Register NAP server and adds bnep bridge. Removes bridge
on destroy call. Bridge mechanism is needed when device acting
as a server and listen for incoming connections.
---
android/pan.c | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 112 insertions(+), 4 deletions(-)
diff --git a/android/pan.c b/android/pan.c
index 38e353d..93f712f 100644
--- a/android/pan.c
+++ b/android/pan.c
@@ -28,6 +28,11 @@
#include <unistd.h>
#include <fcntl.h>
#include <glib.h>
+#include <sys/ioctl.h>
+#include <sys/socket.h>
+#include <sys/wait.h>
+#include <net/if.h>
+#include <linux/sockios.h>
#include "btio/btio.h"
#include "lib/bluetooth.h"
@@ -49,7 +54,7 @@
static bdaddr_t adapter_addr;
GSList *devices = NULL;
uint8_t local_role = HAL_PAN_ROLE_NONE;
-static uint32_t record_id = 0;
+char bridge[5] = "bnep\0";
This last line raises several questions. Firstly, C-strings have an
implicit nul-character at the end so no need to explicitly try to add
one there. You also don't need to have an explicit size between the
square brackets since this is automatically calculated if you do
initialization upon declaration. Why isn't this static? Why isn't it
const? Would a simple define make more sense instead of a dedicated
variable?
I tried these but there are some warnings.
#define BNEP_BRIDGE "bnep"
static char bridge[] = "bnep";
static char *bridge = "bnep";
==10198== Warning: noted but unhandled ioctl 0x89a1 with no
size/direction hints
==10198== This could cause spurious value errors to appear.
==10198== See README_MISSING_SYSCALL_OR_IOCTL for guidance on writing
a proper wrapper.
char bridge[5] = "bnep\0"; worked fine (yes, like you said static can be used).
Regards,
Ravi.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
