Re: [PATCH BlueZ 00/12] Fixes detected by clang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lizardo,

On Fri, Jan 03, 2014, Anderson Lizardo wrote:
> The patches on this set (except for the last patch) fix issues detected while
> building BlueZ with clang. Note that these fixes were only compile tested (I
> did run "make check" but it obviously does not cover code touched by these
> patches). For strncat/sprintf/sscanf related patches, I did some tests with
> sample code to make sure the changes worked as expected.
> 
> The last patch is a fix that I think should be inoffensive (unless there is
> some clever hack going on there that I could not see.)
> 
> BTW, I've been experimenting with Travis CI for automatically running
> build/unit tests for commits made on my personal development tree:
> https://travis-ci.org/lizardo/bluez-devel. Enabling builds with clang (along
> with gcc) was a one-line change to the configuration file. I plan in near
> future to also run functional tests (right now it just runs "make check" and
> "make distcheck")
> 
> Best Regards,
> Anderson Lizardo
> 
> Anderson Lizardo (12):
>   tools: Fix strncat() usage in hciconfig/hcitool
>   avrcp: Remove unnecessary "if (...)"
>   health: Fix struct mcap_csp "csp_req" field type
>   attrib: Fix sprintf() format specification
>   core: Fix sscanf() format specification
>   tools: Fix unaligned memory access on smp-tester
>   tools: Fix possible uninitialized variable in obexctl
>   android/client: Fix incorrect usage of bt_state_t2str()
>   android/client: Remove duplicate "const" specifier
>   android/client: Use memcpy() for getting CMSG_DATA()
>   android/client: Fix uninitialized "sock_fd" variable
>   android/system-emulator: Remove useless "static" qualifier
> 
>  android/client/if-bt.c      |  2 +-
>  android/client/if-hh.c      | 16 ++++++++--------
>  android/client/if-pan.c     |  8 ++++----
>  android/client/if-sock.c    |  8 +++-----
>  android/system-emulator.c   |  3 +--
>  profiles/audio/avrcp.c      |  2 +-
>  profiles/health/mcap_sync.c |  2 +-
>  src/adapter.c               | 12 ++++++------
>  src/attrib-server.c         |  2 +-
>  tools/hciconfig.c           | 21 ++++++++++++++-------
>  tools/hcitool.c             | 23 +++++++++++++++--------
>  tools/obexctl.c             |  6 ++----
>  tools/smp-tester.c          | 16 +++++++++++-----
>  13 files changed, 68 insertions(+), 53 deletions(-)

All patches have been applied. Thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux