Re: [PATCHv2] btdev: Return Command Status for Authentication Requested

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

>> Add support for "Authentication Requested" command
>> ---
>> emulator/btdev.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>> 
>> diff --git a/emulator/btdev.c b/emulator/btdev.c
>> index 93361cd..0349f8a 100644
>> --- a/emulator/btdev.c
>> +++ b/emulator/btdev.c
>> @@ -269,6 +269,7 @@ static void set_bredr_commands(struct btdev *btdev)
>> 	btdev->commands[0]  |= 0x80;	/* Cancel Create Connection */
>> 	btdev->commands[1]  |= 0x01;	/* Accept Connection Request */
>> 	btdev->commands[1]  |= 0x02;	/* Reject Connection Request */
>> +	btdev->commands[1]  |= 0x80;	/* Authentication Requested */
>> 	btdev->commands[2]  |= 0x08;	/* Remote Name Request */
>> 	btdev->commands[2]  |= 0x10;	/* Cancel Remote Name Request */
>> 	btdev->commands[2]  |= 0x20;	/* Read Remote Supported Features */
>> @@ -1202,6 +1203,12 @@ static void default_cmd(struct btdev *btdev, uint16_t opcode,
>> 		cmd_status(btdev, BT_HCI_ERR_SUCCESS, opcode);
>> 		break;
>> 
>> +	case BT_HCI_CMD_AUTH_REQUESTED:
>> +		if (btdev->type == BTDEV_TYPE_LE)
>> +			goto unsupported;
>> +		cmd_status(btdev, BT_HCI_ERR_SUCCESS, opcode);
>> +		break;
>> +
>> 	case BT_HCI_CMD_REMOTE_NAME_REQUEST:
>> 		if (btdev->type == BTDEV_TYPE_LE)
>> 			goto unsupported;
> 
> I'd rather wait with this one until you've got a full set of patches
> that also implement the link key request event and the rest of the
> pairing procedure (if the link key request is followed by a negative
> link key reply).

since we do not install btvirt, I am fine if we even have incomplete functionality in it. However in this case we need to track if pairing is active. And also timeout the pairing. Otherwise everything will be blocked after one attempt.

So at minimum we need to store the current auth request state + start a timeout to make it timeout and send the auth failed event.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux