[PATCH] android/tester: Fix possible NULL dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>

value is checked for NULL and later is dereferenced if we do not return.
---
 android/android-tester.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/android/android-tester.c b/android/android-tester.c
index 2d1ffde..0383115 100644
--- a/android/android-tester.c
+++ b/android/android-tester.c
@@ -148,18 +148,21 @@ static void test_device_property(bt_property_t *property,
 	if (value == NULL) {
 		tester_warn("NULL property passed");
 		tester_test_failed();
+		return;
 	}
 
 	if (property->type != type) {
 		tester_warn("Wrong remote property type %d, expected %d",
 							type, property->type);
 		tester_test_failed();
+		return;
 	}
 
 	if (property->len != len) {
 		tester_warn("Wrong remote property len %d, expected %d",
 							len, property->len);
 		tester_test_failed();
+		return;
 	}
 
 	if (memcmp(property->val, value, len)) {
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux