Hi Marcel, On Fri, Dec 20, 2013 at 3:52 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Luiz, > >>>> This use dup to create a new fd to be used by AVDTP session leaving the >>>> caller free to close the original fd. Note that even if the caller >>>> decides to keep the original fd it will still be notified when >>>> avdtp_shutdown is called since it uses shutdown. >>> >>> I would be more curious on why this is needed. >> >> It is basically to make the caller able to release any resources, such >> as GIOChannel managed by btio, without causing a disconnect. > > you do not have to set close_on_unref with the GIOChannel. You can just unset that one. Then GIOChannel will not touch it and will not call close on it. That is what we used to do, but it is not very convenient since there it is still possible to call g_io_channel_shutdown which would cause a disconnect. Also dup turn out to be handful to check if the fd is valid and free the user to do whatever it pleases with the original fd, in the end what we are doing with the fd is very similar to what we would do to a GIOChannel as dup just creates another reference the underline socket is the same. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
