Hi Szymon,
On Fri, Dec 20, 2013 at 6:25 AM, Szymon Janc <szymon.janc@xxxxxxxxx> wrote:
> +#if PLATFORM_SDK_VERSION > 17
> +static int le_test_mode(uint16_t opcode, uint8_t *buf, uint8_t len)
> +{
> + uint8_t cmd_buf[sizeof(struct hal_cmd_dut_mode_send) + len];
> + struct hal_cmd_le_test_mode *cmd = (void *) cmd_buf;
You are using two different structs above (which happen to have the
same fields).
> +
> + DBG("opcode %u len %u", opcode, len);
> +
> + if (!interface_ready())
> + return BT_STATUS_NOT_READY;
> +
> + cmd->opcode = opcode;
> + cmd->len = len;
> + memcpy(cmd->data, buf, cmd->len);
> +
> + return hal_ipc_cmd(HAL_SERVICE_ID_BLUETOOTH, HAL_OP_LE_TEST_MODE,
> + sizeof(cmd_buf), cmd, 0, NULL, NULL);
Just to be consistent above, I would use "..., sizeof(cmd_buf),
cmd_buf, ...", although I noticed other similar code already upstream.
Best Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
