Hi Szymon,
On Fri, Dec 20, 2013, Szymon Janc wrote:
> > Free device structure allocated during open_bluetooth().
> > ---
> > android/android-tester.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/android/android-tester.c b/android/android-tester.c
> > index 7d7ed88..6007797 100644
> > --- a/android/android-tester.c
> > +++ b/android/android-tester.c
> > @@ -109,6 +109,7 @@ struct test_data {
> > const void *test_data;
> > pid_t bluetoothd_pid;
> >
> > + hw_device_t *device;
> > const bt_interface_t *if_bluetooth;
> > const btsock_interface_t *if_sock;
> >
> > @@ -838,6 +839,8 @@ static void setup(struct test_data *data)
> > return;
> > }
> >
> > + data->device = device;
> > +
> > data->if_bluetooth = ((bluetooth_device_t *)
> > device)->get_bluetooth_interface();
> > if (!data->if_bluetooth) {
> > @@ -882,6 +885,9 @@ static void teardown(const void *test_data)
> > data->if_bluetooth = NULL;
> > }
> >
> > + if (data->device)
> > + free(data->device);
>
> There is no need to check pointer before passing it to free().
The bigger issue here is that the ->open() caller shouldn't know how the
memory was allocated (or if it was allocated at all for that matter - it
might just be a static variable).
This is really a failure of the API since it doesn't provide a ->close()
callback that could do the right thing.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
