Hi Luiz, On Mon, Dec 16, 2013 at 7:31 PM, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > Hi Lukasz, > > On Mon, Dec 16, 2013 at 6:27 PM, Lukasz Rymanowski > <lukasz.rymanowski@xxxxxxxxx> wrote: >> Hi Luiz, >> >> >> On Mon, Dec 16, 2013 at 2:08 PM, Luiz Augusto von Dentz >> <luiz.dentz@xxxxxxxxx> wrote: >>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> >>> >>> This IPC is used to communicate Android BlueZ daemon and AudioFlinger >>> plugin. >>> --- >>> v2: Rework IPC commands to match Android Audio HAL >>> >>> android/Makefile.am | 3 +- >>> android/audio-ipc-api.txt | 85 +++++++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 87 insertions(+), 1 deletion(-) >>> create mode 100644 android/audio-ipc-api.txt >>> >>> diff --git a/android/Makefile.am b/android/Makefile.am >>> index 79f30d7..ac00bb2 100644 >>> --- a/android/Makefile.am >>> +++ b/android/Makefile.am >>> @@ -111,4 +111,5 @@ EXTRA_DIST += android/Android.mk android/hal-ipc-api.txt android/README \ >>> android/pixit-gap.txt android/pixit-hid.txt \ >>> android/pixit-opp.txt android/pixit-pan.txt \ >>> android/pixit-pbap.txt android/pts-gap.txt android/pts-hid.txt \ >>> - android/pts-opp.txt android/pts-pbap.txt >>> + android/pts-opp.txt android/pts-pbap.txt \ >>> + android/audio-ipc-api.txt >>> diff --git a/android/audio-ipc-api.txt b/android/audio-ipc-api.txt >>> new file mode 100644 >>> index 0000000..e9a2136 >>> --- /dev/null >>> +++ b/android/audio-ipc-api.txt >>> @@ -0,0 +1,85 @@ >>> +Bluetooth Audio Plugin >>> +====================== >>> + >>> +The audio plugin happen to be in a different socket but all the rules for >>> +HAL socket apply here as well, the abstract socket name is >>> +"\0bluez_audio_socket" (tentative): >>> + >>> + .--Android--. .---Audio---. >>> + | daemon | | Plugin | >>> + | | Command | | >>> + | | <-------------------------- | | >>> + | | | | >>> + | | --------------------------> | | >>> + | | Response | | >>> + | | | | >>> + | | | | >>> + | | | | >>> + '-----------' '-----------' >>> + >>> + >>> + Audio HAL Daemon >>> + ---------------------------------------------------- >>> + >>> + call dev->open() --> command 0x01 >>> + return dev->open() <-- response 0x01 >>> + >>> + call dev->open_output_stream() --> command 0x03 >>> + return dev->open_output_stream() <-- response 0x03 >>> + >>> + call stream_in->read() --> command 0x05 >>> + return stream_in->read() <-- response 0x05 >>> + >> I think it should be stream_out->write() here. >> >>> + call stream_in->common.standby() --> command 0x06 >>> + return stream_in->common.standby() <-- response 0x06 >>> + >> Also here: stream_out->common.standby() > > I guess it should work both ways, but perhaps Android is never meant > to sink role nevertheless I would not limit the IPC to just source as > it could be useful and it doesn't need that much to work. > I agree that it should work for stream in as well, and actually I can imagine product based on Android acting as SINK on A2DP. Anyway, maybe it would be better to point it out directly and keep HAL calls example for stream out. /Łukasz > -- > Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
