Hi Ravi, On Fri, Dec 13, 2013, Ravi kumar Veeramally wrote: > Refactored bnep connect and disconnect calls to simply and > keeping bnep related functionality behind curtains. > Provided bnep_struct, bnep_new and bnep_free to intialize > and free the bnep_stuct with basic parameters. bnep_connect > calls takes care of bnep_setup until interface up then connect > callback will be called, disconnect_cb is registered as watchdog > and it will triggered by remote device on disconnect or any other > I/O error. bnep_disconnect should be called only when iface is > up/connected. > --- > android/pan.c | 97 ++++++++++++------------------- > profiles/network/bnep.c | 131 ++++++++++++++++++++++++++++++------------ > profiles/network/bnep.h | 14 +++-- > profiles/network/connection.c | 50 ++++++++++------ > 4 files changed, 173 insertions(+), 119 deletions(-) This is a bit too much stuff in a single patch which makes it hard to follow exactly what the patch is doing. Could you please try to split this up into multiple patches? Thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html