Re: [PATCH 19/31] Bluetooth: Implement returning of LE L2CAP credits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On 16:11 Wed 04 Dec, Johan Hedberg wrote:
> From: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> 
> We should return credits to the remote side whenever they fall below a
> certain level (in our case under half of the initially given amount).
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> ---
>  net/bluetooth/l2cap_core.c | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 8a1c528908fb..b99bdc53c57b 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -2542,8 +2542,10 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len,
>  	}
>  
>  	switch (chan->mode) {
> -	case L2CAP_MODE_BASIC:
>  	case L2CAP_MODE_LE_FLOWCTL:
> +		chan->tx_credits--;
> +		/* fall through */

I guess that this change makes more sense in the next commit, no?

> +	case L2CAP_MODE_BASIC:
>  		/* Check outgoing MTU */
>  		if (len > chan->omtu)
>  			return -EMSGSIZE;
> @@ -6608,6 +6610,32 @@ drop:
>  	return 0;
>  }
>  


Cheers,
-- 
Vinicius
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux