Hi Szymon,
On Tue, Nov 19, 2013, Szymon Janc wrote:
> Properties types are verified on daemon side and proper error is
> returned on wrong type. No need to double check that on HAL side.
> ---
> android/hal-bluetooth.c | 15 ---------------
> 1 file changed, 15 deletions(-)
All patches in this set have been applied. Thanks.
> --- a/android/hal-bluetooth.c
> +++ b/android/hal-bluetooth.c
> @@ -476,21 +476,6 @@ static int get_adapter_property(bt_property_type_t type)
> if (!interface_ready())
> return BT_STATUS_NOT_READY;
>
> - switch (type) {
> - case BT_PROPERTY_BDNAME:
> - case BT_PROPERTY_BDADDR:
> - case BT_PROPERTY_UUIDS:
> - case BT_PROPERTY_CLASS_OF_DEVICE:
> - case BT_PROPERTY_TYPE_OF_DEVICE:
> - case BT_PROPERTY_SERVICE_RECORD:
> - case BT_PROPERTY_ADAPTER_SCAN_MODE:
> - case BT_PROPERTY_ADAPTER_BONDED_DEVICES:
> - case BT_PROPERTY_ADAPTER_DISCOVERY_TIMEOUT:
> - break;
> - default:
> - return BT_STATUS_PARM_INVALID;
> - }
> -
We should be consistent about this across all HALs. I just applied
patches from Ravi that added validity check to the HAL side, however now
it seems these should actually be on the daemon side (and now that I
think about it the daemon must in the name of robustness check them
anyway).
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
