Re: [PATCH 3/5] android: Handle multiple init(register) and cleanup(unregister) calls properly

[Ravi Kumar Veeramally <ravikumar.veeramally@xxxxxxxxxxxxxxx>]

Hi,

On 11/19/2013 03:30 PM, Johan Hedberg wrote:
> Hi Ravi,
>
> On Tue, Nov 19, 2013, Ravi kumar Veeramally wrote:
> > @@ -2275,6 +2275,9 @@ bool bt_bluetooth_register(int sk)
> >   {
> >   	DBG("");
> >   
> > +	if (notification_sk > 0)
> 0 is a valid file descriptor value so the check should be >= 0
>
> > @@ -1190,6 +1190,9 @@ bool bt_hid_register(int sk, const bdaddr_t *addr)
> >   
> >   	DBG("");
> >   
> > +	if (notification_sk > 0)
> > +		return false;
> Same here.
>
> > @@ -95,6 +95,9 @@ bool bt_pan_register(int sk, const bdaddr_t *addr)
> >   {
> >   	DBG("");
> >   
> > +	if (notification_sk > 0)
> > +		return false;
> And here.
>
> Johan
 Ok.

 Thanks,
 Ravi.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html