Re: [PATCH_v2 3/4] android/pan: Add notify method to PAN notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On 12.11.2013 19:06, Johan Hedberg wrote:
Hi Ravi,

On Tue, Nov 12, 2013, Ravi kumar Veeramally wrote:
---
  android/hal-pan.c | 6 ++++++
  android/hal.h     | 1 +
  2 files changed, 7 insertions(+)
I've applied the first two patches, but there's one issue with this one:

+void bt_notify_pan(uint16_t opcode, void *buf, uint16_t len)
+{
+	if (!interface_ready())
+		return;
+}
Why is opcode uint16_t instead of uint8_t? Haven't we defined it as
uint8_t in our IPC document?

There are few other places like adapter and hid it is declared as uint16_t.
I will fix that too and send you v3 of these two.

Thanks,
Ravi.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux