Re: [PATCH_v3 1/5] android/hid: Fix set seport ipc cmd preparation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ravi,

On Fri, Nov 08, 2013, Ravi kumar Veeramally wrote:
> Now report data is not fixed array. Allocate proper memory
> and send ipc cmd.
> ---
>  android/hal-hidhost.c | 29 ++++++++++++++++++++---------
>  android/hal-msg.h     |  2 +-
>  2 files changed, 21 insertions(+), 10 deletions(-)
> 
> diff --git a/android/hal-hidhost.c b/android/hal-hidhost.c
> index 34f9f77..ce3dcd7 100644
> --- a/android/hal-hidhost.c
> +++ b/android/hal-hidhost.c
> @@ -18,6 +18,7 @@
>  #include <stdbool.h>
>  #include <stddef.h>
>  #include <string.h>
> +#include <stdlib.h>
>  
>  #include "hal-log.h"
>  #include "hal.h"
> @@ -297,7 +298,8 @@ static bt_status_t set_report(bt_bdaddr_t *bd_addr,
>  						bthh_report_type_t report_type,
>  						char *report)
>  {
> -	struct hal_cmd_hidhost_set_report cmd;
> +	struct hal_cmd_hidhost_set_report *cmd;
> +	int cmd_len, status;

The return type of this function is bt_status_t, not int (even though
the two are in practice compatible).

Are you sure you don't want to keep using a stack variable? You could
potentially just define a buffer with the max mtu size and use that.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux