Hi Lukasz, On Thu, Nov 07, 2013, Lukasz Rymanowski wrote: > Android handles discoverable timeout in Settings app, however still > expects BT stack to maintain this value so we should do it as well. > Otherwise we will get some unexpected behaviour. > For now we keep discovery_timeout only during runtime, but we need to move > it to some local storage once we will have it. > > Note: That since Android Settings up handles timer there is no reason to > use discovery timer we have in kernel. > --- > android/adapter.c | 38 +++++++++++++++++++++++++++++++++++--- > 1 file changed, 35 insertions(+), 3 deletions(-) Applied, but I still had to tweak around the coding style a bit: > + memcpy(&ev->props[0].val, &adapter->discoverable_timeout, > + sizeof(uint32_t)); You can indent this second line more here. General rule is indent as long as you stay under 80 characters. > + ipc_send(notification_sk, HAL_SERVICE_ID_BLUETOOTH, > + HAL_EV_ADAPTER_PROPS_CHANGED, > + sizeof(buf), ev, -1); Here you're not only under-indented but the second continuation line doesn't match the first continuation line (the coding style is to keep lines 2-n with the same indentation). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
