Re: [PATCH] Bluetooth: Remove unnecessary 'send' parameter from smp_failure()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lizardo,

On Wed, Nov 06, 2013, Anderson Lizardo wrote:
> On Wed, Nov 6, 2013 at 9:31 AM, Anderson Lizardo
> <anderson.lizardo@xxxxxxxxxxxxx> wrote:
> > Hi Johan,
> >
> > On Wed, Nov 6, 2013 at 5:24 AM,  <johan.hedberg@xxxxxxxxx> wrote:
> >
> >> @@ -895,7 +895,7 @@ int smp_sig_channel(struct l2cap_conn *conn, struct sk_buff *skb)
> >>                 break;
> >>
> >>         case SMP_CMD_PAIRING_FAIL:
> >> -               smp_failure(conn, skb->data[0], 0);
> >> +               smp_failure(conn, 0);
> >
> > I think you meant "smp_failure(conn, skb->data[0]);" here.
> 
> My bad, I see now that the purpose is to not send an error in this case.

Exactly. Which is why the original code was misleading in that you might
have thought it actually did something with skb->data[0].

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux