Hi Johan, Marcel
On 6 November 2013 09:41, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Johan,
>
>>> It will set class of device with proper service hints.
>>> We set it statically because we want to keep code simple.
>>>
>>> ---
>>> android/adapter.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 59 insertions(+)
>>
>> I've applied patches 1-3, but am a bit confused about this one.
>>
>>> diff --git a/android/adapter.c b/android/adapter.c
>>> index 0f24cac..70b9265 100644
>>> --- a/android/adapter.c
>>> +++ b/android/adapter.c
>>> @@ -52,6 +52,29 @@ static GIOChannel *notification_io = NULL;
>>> /* This list contains addresses which are asked for records */
>>> static GSList *browse_reqs;
>>>
>>> +/*
>>> + * This is an array of supported uuids and service hints. We add them via mgmt
>>> + * interface when adapter is initialized. Uuids are in reverse orded.
>>> + */
>>> +static const struct mgmt_cp_add_uuid supported_services[] = {
>>> + /* OBEX_OPP_UUID */
>>> + { .uuid = { 0xfb, 0x34, 0x9b, 0x5f, 0x80, 0x00, 0x00, 0x80,
>>> + 0x00, 0x10, 0x00, 0x00, 0x05, 0x11, 0x00, 0x00 },
>>> + .svc_hint = 0x10 },
>>> + /* HFP_AG_UUID */
>>> + { .uuid = { 0xfb, 0x34, 0x9b, 0x5f, 0x80, 0x00, 0x00, 0x80,
>>> + 0x00, 0x10, 0x00, 0x00, 0x1f, 0x11, 0x00, 0x00 },
>>> + .svc_hint = 0x40 },
>>> + /* ADVANCED_AUDIO_UUID */
>>> + { .uuid = { 0xfb, 0x34, 0x9b, 0x5f, 0x80, 0x00, 0x00, 0x80,
>>> + 0x00, 0x10, 0x00, 0x00, 0x0d, 0x11, 0x00, 0x00 },
>>> + .svc_hint = 0x08 },
>>> + /* PANU_UUID */
>>> + { .uuid = { 0xfb, 0x34, 0x9b, 0x5f, 0x80, 0x00, 0x00, 0x80,
>>> + 0x00, 0x10, 0x00, 0x00, 0x15, 0x11, 0x00, 0x00 },
>>> + .svc_hint = 0x02 }
>>> +};
>>
>> I seem to remember the discussion around this drifting back to doing the
>> registration dynamically. Do I remember wrong? Wasn't it so that at
>> least some UUIDs (such as PAN) with a bluedroid based system only appear
>> when you actually enable support for the profile in the UI?
>
> looking at a Nexus 4, the SDP database seems static. The PAN record is always present.
>
> I think dynamic is on the level do we compile in support for the PAN HAL module or not. So the record and UUID list should come from the PAN module. So it is kinda dynamic in that sense, but ultimately static.
>
> Regards
>
> Marcel
>
Could it look like this:
we will hold that static array off uuids and svc hints and additional
profile_id.
Each profile will call generic method like
adapter_register_profile(profile_id) (just example), and it will add
sdp record to sdp server & uuid to mgmt interface. Profiles
implemented out of stack (I mean opp, pbab etc) will have static sdp
record and uuid which will be added once adapter is initialized. What
is your opinion?
Regards
Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
