Hi David, On Tue, Nov 05, 2013, David Binderman wrote: > Hello there, > > I just ran the static analysis checker "cppcheck" over the source code of bluez-5.10 > > It said > > [monitor/packet.c:4335] -> [monitor/packet.c:4338]: (warning) Variable 'str' is reassigned a value > before the old one has been used. 'break;' missing? > > Source code is > > case 0x03: > str = "Allow Scan Request from White List Only, " > "Allow Connect Request from White List Only"; > default: > str = "Reserved"; > break; > > Suggest add a break statement to the 0x03 case. Yes, that looks like a bug. Do you want to send a proper patch for it? Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
