Hi Seung-Woo, >>> L2CAP socket bind checks its bdaddr type but RFCOMM kernel thread >>> does not assign proper bdaddr type for L2CAP sock. This can cause >>> that RFCOMM failure. >>> >>> Signed-off-by: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> >>> --- >>> The issue is came from following commit, but it is only in bluetooth-next tree, >>> so this patch is not needed for stable tree. >>> >>> commit 80c1a2e76dbb36588facb265ab364b1302f7ef8c >>> Author: Johan Hedberg <johan.hedberg@xxxxxxxxx> >>> Date: Mon Oct 14 21:17:52 2013 +0300 >>> >>> Bluetooth: Reject invalid bdaddr types for sockets >>> >>> This patch is based on commit cca34b785a21d220176038c45071ffe842e99fd3 of >>> bluetooth-next tree. >>> --- >>> net/bluetooth/rfcomm/core.c | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> good catch. Patch has been applied to bluetooth-next tree. >> >> You might also want to send a patch that adds the l2_bdaddr_type setting before the connect() call. > > Case of kernel_connect() in rfcomm_session_create(), it reuses > l2_bdaddr_type used for kernel_bind(), so it works fine for me: I tested > both incoming connection and outgoing connection cases of rfcomm. > But if you prefer explicit setting for connect(), please let me know. I realized that it will just work fine. But it is better style to add an explicit setting in the connect() case as well. It is less error prone in the future. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
